Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port specifications for Namada #169

Merged
merged 15 commits into from
Jul 11, 2022
Merged

Port specifications for Namada #169

merged 15 commits into from
Jul 11, 2022

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jul 8, 2022 •
edited
Loading

This pull request ports the subset of the Anoma specification documents hosted in the specs repo to the Namada repository so that Namada has a standalone specification. I've also taken the liberty to reorganise the documents somewhat and specify a few remaining items.

I have ported anoma/specs from commit 2198767818a56bff6632b4df3d47f2af3a358a99 - any changes made afterwards, or outstanding PRs, will not be reflected and must be manually made against this repository.

Further changes made by this PR:

  • General reorganisation for clarity of Namada components, subsystems, and relations between them
  • Addition of public-goods funding per proposal in https://github.com/anoma/specs/issues/100 (but not full spec)

Instructions for reviewers of this PR

Please render & read the specs locally. This can be done by running

cd documentation/spec; make serve

from the root of the repository. If you have any comments, please comment on the Markdown files directly in the "Files Changed" view on Github, or write a comment on this PR with any more general concerns or suggestions.

@cwgoes cwgoes added documentation Improvements or additions to documentation prio:high spec namada labels Jul 8, 2022
@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 9, 2022 •
edited
Loading

edit: disregard below questions which will be split off to a second PR

Open questions to be addressed:

  • Which validity predicates will be supported (whitelisted) on Namada? All of them should have clear specs and tests. Particularly, do we have support for k-of-n multisignatures which can be deployed (with different keys) by users? Are there any other VPs we would need?
  • Which parts of the fee system are actually implemented at the moment? Can we clarify the part on how transaction fees are split between the next few block proposers? What are all the constants here and what default values do we want to use? What is the state of the gas pricing system at the moment?
  • Are we on the same page about the latest state of inflation and reward distribution (proof-of-stake rewards, shielded pool rewards, public-goods funding)? Which parts of this system are implemented and which are not?

@tzemanovic tzemanovic mentioned this pull request Jul 11, 2022
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 11, 2022

Decided to merge as-is and split off follow-up changes to a separate PR.

@cwgoes cwgoes marked this pull request as ready for review July 11, 2022 15:17
@cwgoes cwgoes changed the title WIP: Port specifications for Namada Port specifications for Namada Jul 11, 2022
@cwgoes cwgoes merged commit c6bc20d into namada Jul 11, 2022
@cwgoes cwgoes deleted the cwgoes/port-specs branch July 11, 2022 15:17
phy-chain pushed a commit to phy-chain/namada that referenced this pull request Mar 1, 2024
@mateuszjasiuk
feat: move integrations to the integrations service (anoma#169)
2fa4198 
* feat: move integrations to the integrations service

* feat: add useWithIntegration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation prio:high spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cwgoes